Skip to content

[Fix] JWT 페이로드 이메일 클레임 제거#239

Merged
pooreumjung merged 1 commit into
developfrom
fix/#216-jwt-email-claim
Jun 19, 2026
Merged

[Fix] JWT 페이로드 이메일 클레임 제거#239
pooreumjung merged 1 commit into
developfrom
fix/#216-jwt-email-claim

Conversation

@pooreumjung

@pooreumjung pooreumjung commented Jun 19, 2026

Copy link
Copy Markdown
Member

🧾 요약

  • JWT 페이로드에 포함된 이메일 클레임 제거 - Base64 디코딩으로 이메일이 노출되는 보안 이슈 수정

🔗 이슈

✨ 변경 내용

  • JwtService.generateAccessToken()에서 .claim("email", ...) 제거

✅ 확인

  • 빌드 OK
  • 테스트 OK

@coderabbitai

coderabbitai Bot commented Jun 19, 2026

Copy link
Copy Markdown

Important

Review skipped

Auto reviews are disabled on this repository. Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: Repository UI

Review profile: CHILL

Plan: Pro Plus

Run ID: c4c6f0eb-e184-4549-93cd-5865988c6343

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • 🔍 Trigger review
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch fix/#216-jwt-email-claim

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@gemini-code-assist

Copy link
Copy Markdown

Summary of Changes

Hello, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

본 PR은 JWT 토큰 생성 로직에서 이메일 정보를 제거하여 보안성을 높이는 것을 목적으로 합니다. 페이로드에 포함된 이메일이 평문으로 노출될 수 있는 위험을 방지하기 위해 해당 클레임을 삭제하였습니다.

Highlights

  • 보안 강화: JWT 페이로드에서 이메일 클레임을 제거하여 Base64 디코딩을 통한 민감 정보 노출 취약점을 해결했습니다.
New Features

🧠 You can now enable Memory (public preview) to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console.

Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize the Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counterproductive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for GitHub and other Google products, sign up here.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.

@pooreumjung pooreumjung self-assigned this Jun 19, 2026
@pooreumjung pooreumjung added the bug Something isn't working label Jun 19, 2026

@gemini-code-assist gemini-code-assist Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request removes the 'email' claim from the JWT access token generation in JwtService.java. No review comments were provided, and there is no additional feedback for this change.

Important

The consumer version of Gemini Code Assist on GitHub is being sunset. Starting June 18, 2026, new organization installations will be blocked, and all code review activity will officially cease on July 17, 2026.
For more details on the timeline and next steps, please review the Help Documentation.

@pooreumjung pooreumjung merged commit c588461 into develop Jun 19, 2026
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[fix] JWT 페이로드에 이메일 포함으로 인한 정보 노출

1 participant