Open
Conversation
esimpsons3ti
approved these changes
Oct 15, 2024
Collaborator
|
@dstopp: I wonder whether it might be good for you to take 10 minutes to look this over and consider whether this still has useful content and should be squashed and merged, or whether it has been superseded and should be closed as wontfix. @markshowalter thinks that nothing here would affect what you've been doing, in which case maybe we should just squash and merge. But then we may not know what you've been doing, so please take a look. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request addresses the issues with strings vs. bytestrings in Python 3. I also added a file HTML_SYMBOLS.py which does a better job of encoding special characters in the Jekyll files produced.
Note that I have also deleted from all history the jekyll/ subdirectory. This was huge (> 22,000 files) and should not have been in the repo. This directory contained the output files produced by the pipeline. Normally these should go into a separate directory defined by the environment variable JEKYLLPATH for staging them to be uploaded to the website.