Conversation
WalkthroughRemoved Python 3.8 support from CI and project metadata, added rms-filecache (and rms-julian in pyproject) as dependencies, updated README to document FCPath-supported input paths and broadened allowed value types, and replaced pathlib-based file handling with filecache.FCPath in textkernel.from_file. Changes
Estimated code review effort🎯 3 (Moderate) | ⏱️ ~20 minutes
Pre-merge checks✅ Passed checks (5 passed)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #10 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 5 5
Lines 326 326
Branches 67 67
=========================================
Hits 326 326 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
markshowalter
left a comment
There was a problem hiding this comment.
Please make the change "latin8" to "latin1". Then you can squash and merge.
textkernel/__init__.py
Outdated
| """ | ||
|
|
||
| text = pathlib.Path(path).read_text(encoding='latin8') | ||
| text = filecache.FCPath(path).read_text(encoding='latin8') |
There was a problem hiding this comment.
This is an older bug. Should be "latin1", not "latin8". Please fix.
There was a problem hiding this comment.
Actionable comments posted: 1
📜 Review details
Configuration used: CodeRabbit UI
Review profile: ASSERTIVE
Plan: Pro
📒 Files selected for processing (1)
textkernel/__init__.py(3 hunks)
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (1)
- GitHub Check: Test textkernel (windows-latest, 3.10)
🔇 Additional comments (1)
textkernel/__init__.py (1)
310-311: LGTM! Clear documentation of FCPath support.The docstring accurately documents that
FCPathis now a supported path type alongside strings andPathobjects.
Fixed Issues
Summary of Changes
Known Problems
Summary by CodeRabbit
Chores
New Features
Documentation
✏️ Tip: You can customize this high-level summary in your review settings.