Replace deprecated pyparsing oneOf with one_of#12
Conversation
Fixes #11. Replaces all uses of the deprecated `oneOf` with the current `one_of` API in _DATA_GRAMMAR.py and _NAME_GRAMMAR.py to eliminate PyparsingDeprecationWarning. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
|
Warning Rate limit exceeded
Your organization is not enrolled in usage-based pricing. Contact your admin to enable usage-based pricing to continue reviews beyond the rate limit, or try again in 10 minutes and 25 seconds. ⌛ How to resolve this issue?After the wait time has elapsed, a review can be triggered using the We recommend that you space out your commits to avoid hitting the rate limit. 🚦 How do rate limits work?CodeRabbit enforces hourly rate limits for each developer per organization. Our paid plans have higher rate limits than the trial, open-source and free plans. In all cases, we re-allow further reviews after a brief timeout. Please see our FAQ for further information. ℹ️ Review info⚙️ Run configurationConfiguration used: Organization UI Review profile: ASSERTIVE Plan: Pro Run ID: 📒 Files selected for processing (2)
WalkthroughThe PR replaces the deprecated Changes
Estimated code review effort🎯 2 (Simple) | ⏱️ ~8 minutes Possibly related issues
🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #12 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 5 5
Lines 326 326
Branches 67 67
=========================================
Hits 326 326 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
There was a problem hiding this comment.
Actionable comments posted: 1
🤖 Prompt for all review comments with AI agents
Verify each finding against the current code and only fix it if needed.
Inline comments:
In `@textkernel/_DATA_GRAMMAR.py`:
- Line 12: The project uses pyparsing.one_of() (imported as one_of) which
requires pyparsing>=3.0.0; update the dependency constraints by adding a minimum
version specifier "pyparsing>=3.0.0" to both pyproject.toml (dependencies) and
requirements.txt so installations cannot pick pre-3.0 releases, and run your
dependency install/lock step to propagate the change.
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: Organization UI
Review profile: ASSERTIVE
Plan: Pro
Run ID: 75b27e8d-807f-421d-b7d6-70419f669c8c
📒 Files selected for processing (2)
textkernel/_DATA_GRAMMAR.pytextkernel/_NAME_GRAMMAR.py
one_of() was introduced in pyparsing 3.0.0; without this floor an install of pyparsing<3.0 would fail at import time. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
Summary
oneOfwithone_of(PyparsingDeprecationWarning) #11oneOfwithone_ofin_DATA_GRAMMAR.pyand_NAME_GRAMMAR.pyPyparsingDeprecationWarning: 'oneOf' deprecated - use 'one_of'on recent pyparsing versionsTest plan
pytest tests/ -v)-W error::DeprecationWarningto confirm no deprecation warnings remain🤖 Generated with Claude Code
Summary by CodeRabbit