Removed console logs and fixed small privy login error#32
Open
SanchezOLeary wants to merge 3 commits into
Open
Removed console logs and fixed small privy login error#32SanchezOLeary wants to merge 3 commits into
SanchezOLeary wants to merge 3 commits into
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
paulgoleary
requested changes
Jan 8, 2026
| setIsProcessing(true) | ||
| try { | ||
| //Token conversion call goes here | ||
| console.log("Token Conversion") |
Collaborator
There was a problem hiding this comment.
Is this a placeholder for future work? Otherwise, doesn't make sense to leave the try.
| placeAutocomplete.className="text-black dark:text-white border rounded-md bg-secondary px-3 py-2" | ||
|
|
||
| if (containerRef.current?.querySelector("gmp-place-autocomplete")) { | ||
| console.log("Element is already inside container"); |
Collaborator
There was a problem hiding this comment.
Strange to leave the positive case here; should just have the single negative case.
| setIsConvertingToPaypal(true) | ||
| try { | ||
| // PayPal offload called here | ||
| console.log("PayPal offload") |
Collaborator
There was a problem hiding this comment.
Same as above - is this a place holder for future work? If so prefix with comment with TODO 😄
|
|
||
| const toastFunction = React.useCallback(({ title, description, variant = "default" }: ToastProps) => { | ||
| // Mock toast implementation | ||
| console.log(`Toast: ${title} - ${description} (${variant})`) |
Collaborator
There was a problem hiding this comment.
Prob makes sense to leave the log here if this is intended to be default / mock impl.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
lgtm be might a few more cleanup items.