Open
Conversation
Owner
|
This looks great! Apologies for the slow reply. Thank you for your contribution. I was thinking about dockerising it myself only a few weeks ago. |
Author
|
Hi @SKrisanski. Maybe this PR is very large, i noticed. |
Owner
|
Hi Sergio, Sorry I haven't got to it yet. No need to make it smaller, I'm just a bit short on time currently (I've been away from home for the last few weeks for work), so haven't had time to go through it thoroughly yet. Thanks again for the PR. |
|
Hi @SKrisanski , Any updates on the possibility of merging the dockerization changes to master? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Main changes: