fix: update entity dispatcher in CreateShopView and bump version to 1…#25
Merged
Conversation
twisti-dev
approved these changes
May 22, 2026
There was a problem hiding this comment.
Pull request overview
This PR updates the Folia coroutine dispatcher used in CreateShopView to run player UI operations on the correct entity thread, and bumps the project version to 1.3.3.
Changes:
- Replaced
globalRegionDispatcherusage withentityDispatcher(player)when closing the inventory and opening the next view after shop creation. - Updated
gradle.propertiesproject version from1.3.2to1.3.3.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| surf-shop-paper/src/main/kotlin/dev/slne/surf/shop/paper/menu/CreateShopView.kt | Ensures post-create UI actions run on the player’s entity dispatcher (Folia-safe). |
| gradle.properties | Bumps the project version to 1.3.3. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
….3.3