Find the results dir based on the example script file location.#68
Open
zuckerruebe wants to merge 1 commit intomainfrom
Open
Find the results dir based on the example script file location.#68zuckerruebe wants to merge 1 commit intomainfrom
zuckerruebe wants to merge 1 commit intomainfrom
Conversation
Contributor
Author
|
@sebastian-swob: Would you now increase the fix version for this merge request? |
Contributor
|
@zuckerruebe Yes I would merge main into this branch and then increase the version in the toml file |
Contributor
|
@zuckerruebe Why would you run the processing example outside of the cloned git repo? |
Contributor
Author
Because I wanted to test an installation of |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When dong
pip install pytrnsys-processin a fresh environment and then running theprocessing_example.pyscript from somewhere else (git clone of the source repo, unrelated to my newvenvinto which I've "pip installed"pytrnsys-process) then I get the following errorThis is because the script assumes that the directory layout is as it would be in a developer install. I've changed the paths of the script so that it should work independently of how/where it is run.
However, I've not checked whether this still works in a development install. Furthermore, I'm not sure if
api.REPO_ROOTis still needed now? Maybe not and it can be removed? I know it's still referenced in some places, but I mean whether it's still neded theoretically or whether it could be refactored away. I don't mind it being there, just that having removed one reference now, I wanted you to double check.Cheers