Open
Conversation
fanny
reviewed
Dec 10, 2020
fanny
suggested changes
Dec 10, 2020
| @@ -0,0 +1,122 @@ | |||
| const util = require("../util"); | |||
There was a problem hiding this comment.
Why are there the same files of moenda? Isn't better to communicate with the moenda app instead of replicate each file? How do you plan keep them sync?
There was a problem hiding this comment.
My suggestion is download the moenda app and use the modules exported by the app
| test('ruleFirstSectionStartsWithHx returns object', | ||
| () => { | ||
| const object = mdRoules.ruleFirstSectionStartsWithHx("/home/felipe/fork/Moenda/README.md", "/home/felipe/fork/Moenda/config.js"); | ||
| expect("object").toBe(typeof object); |
There was a problem hiding this comment.
Is not better to compare the content instead of the types? What are the advantages doing that?
| @@ -0,0 +1,22 @@ | |||
| var Git = require("nodegit"); | |||
There was a problem hiding this comment.
Do not use var, there are some inconsistencies caused by it, also JavaScript doesn't start the variables name with uppercase
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Todos arquivos contidos na pasta "backend" são iguais aos que já foram revisados no "Moenda", não necessitando portanto de nova revisão. As implementações que acredito que precisem de revisão são as da pasta "services", "app.js" e "server.js".