TSK-012-03 App shell subnav grid layout#414
Merged
Merged
Conversation
17 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
요약
AppShell에 optionalsubNav슬롯과app-shell--with-subnav/app-shell--no-subnav변형을 추가했습니다.MapTabStage내부 오버레이에서 shell subNav flow 슬롯으로 이동했습니다.MapTabStage는 map surface와 sheet 렌더링만 담당하도록 props contract를 줄였습니다.Closes #407
Architecture Boundary Gate
AppShell은 header/subNav/content/bottom-tab 슬롯을 소유하고,AppMapStageSubNav는 map-local subNav composition만 소유합니다.App.tsx -> AppShell이 슬롯을 조립하고,AppMapStageView.tsx -> MapStageCategoryStrip방향으로 map category UI를 위임합니다..map-filter-strip와.map-surface-frame의 기존 offset debt는 #410에서 계속 정리해야 합니다.검증
npm.cmd run check:numeric-literals통과npm.cmd run lint통과npm.cmd run typecheck통과npm.cmd run test:unit통과npm.cmd run test:integration통과npm.cmd run test:regression통과npm.cmd run test:e2e통과npm.cmd run build통과git diff --check통과