Skip to content

fix: improve tourism info data consumption#422

Merged
ClarusIubar merged 1 commit into
mainfrom
tourism-info-data-consumption-fix
Jun 13, 2026
Merged

fix: improve tourism info data consumption#422
ClarusIubar merged 1 commit into
mainfrom
tourism-info-data-consumption-fix

Conversation

@ClarusIubar

Copy link
Copy Markdown
Contributor

Summary

  • render KTO tourism image, summary, description, category, district, source, and homepage link in the information sheet
  • pass an AbortSignal through the tourism API client and stop indefinite tourism loading after a configured timeout
  • add component/API regression tests and completion evidence for TSK-013-01

Architecture Boundary Gate

  • Responsibility map: tourismClient owns the Worker consumer request; useAppCoordinatorEffects owns request lifecycle/timeout; TourismInfoSheet owns normalized TourismPlaceItem presentation.
  • Dependency direction: UI effect -> API client -> fetchJson; presentation component -> TourismPlaceItem. Browser code still does not call KTO/OpenAPI, Supabase, or admin import APIs directly.
  • Test seam: component render assertions for rich KTO fields; API client assertion for RequestInit.signal forwarding.
  • Scope map: frontend data consumption and timeout guard only. API path, response shape, DB schema, OAuth flow, and curated place stamp/review flow unchanged.
  • Architecture risk: KTO info pins must stay information-only, not curated place action surfaces; this PR does not add stamp/review/feed actions.

Validation

  • npm.cmd run check:numeric-literals
  • npm.cmd run lint
  • npm.cmd run typecheck
  • npm.cmd run test:unit -- tourism-info-sheet tourism-client
  • npm.cmd run test:unit
  • npm.cmd run test:integration
  • npm.cmd run test:regression
  • npm.cmd run test:e2e
  • npm.cmd run build
  • git diff --check
  • UTF-8 strict read for changed source/test files

Closes #421

@ClarusIubar ClarusIubar merged commit 729cbe8 into main Jun 13, 2026
6 checks passed
@ClarusIubar ClarusIubar deleted the tourism-info-data-consumption-fix branch June 13, 2026 05:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

TSK-013-01 KTO tourism info sheet data consumption and timeout guard

1 participant