Skip to content

fix: restore mobile map location and tourism sheet layout#427

Merged
ClarusIubar merged 1 commit into
mainfrom
mobile-map-location-sheet-fix
Jun 13, 2026
Merged

fix: restore mobile map location and tourism sheet layout#427
ClarusIubar merged 1 commit into
mainfrom
mobile-map-location-sheet-fix

Conversation

@ClarusIubar

Copy link
Copy Markdown
Contributor

Summary

  • fix current-location flow by forwarding map location messages to NaverMapStatus and removing a watchPosition watchId initialization race
  • restore readable current-location and tourism visible copy touched by this map UX flow
  • compose TourismInfoSheet with a shared MapBottomSheet shell, open KTO info sheets in full mode, and add full-sheet bottom padding so content is not hidden behind the tab bar
  • add regression tests for geolocation, map location status UI, and tourism sheet bottom-sheet structure

Architecture Boundary Gate

  • Responsibility map: geolocation.ts owns browser geolocation normalization; NaverMapStatus owns map location UI feedback; MapBottomSheet owns common map sheet shell; TourismInfoSheet owns KTO read-only presentation.
  • Dependency direction: app coordinator -> map stage -> Naver map/status -> geolocation callback. Tourism sheet consumes TourismPlaceItem only and does not call KTO/OpenAPI, Worker, Supabase, or admin APIs.
  • Test seam: browser geolocation mocked at public API boundary; status UI tested through rendered controls/messages; tourism sheet tested through shared shell classes and full state.
  • Scope map: frontend map UX only. API path, response shape, DB schema, OAuth, Worker/Admin KTO import flow unchanged.
  • Architecture risk: bottom tab remains a separate app-shell overlay, so full sheet content receives bottom padding rather than changing global tab visibility policy in this bug fix.

Validation

  • npm.cmd run typecheck
  • npm.cmd run test:unit -- geolocation naver-map-status tourism-info-sheet map-config
  • npm.cmd run check:numeric-literals
  • npm.cmd run lint
  • npm.cmd run test:integration
  • npm.cmd run test:regression
  • npm.cmd run test:e2e
  • npm.cmd run build
  • git diff --check
  • UTF-8 strict read / commit hook

Closes #426

@ClarusIubar ClarusIubar merged commit 1991601 into main Jun 13, 2026
6 checks passed
@ClarusIubar ClarusIubar deleted the mobile-map-location-sheet-fix branch June 13, 2026 06:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

TSK-014-01 Mobile map location and tourism sheet layout fix

1 participant