feat(BOR-455): add macOS mount POC scaffold#16
feat(BOR-455): add macOS mount POC scaffold#16bdclaw2026 wants to merge 3 commits intoSTRRL:mainfrom
Conversation
|
@claude please review this PR |
|
@codex please review this PR |
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: c423255bbd
ℹ️ About Codex in GitHub
Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".
Absolute filesystem paths like /docs/readme.txt were failing to match seeded keys like docs/readme.txt, causing incorrect 404s. Strip the leading slash before using path as a dictionary key in both read and write. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
|
@claude please review this PR |
|
@codex review |
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: a2904f58c1
ℹ️ About Codex in GitHub
Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".
The list method only special-cased exact "/" but did not strip leading slashes from other absolute prefixes like "/docs/", unlike read and write which already did. This caused mounted directories to appear empty when FSKit or other callers passed POSIX-style absolute paths. Addresses Codex review comment on PR STRRL#16.
2 participants
Summary
poc/macos-mountSwift package scaffold for mount pipeline explorationValidation
cd poc/macos-mount && swift run MountPOCpassesTicket
Status