Skip to content

BOR-487: Add E2E automation for core S3 Studio flows#20

Merged
bdclaw2026 merged 1 commit intoSTRRL:mainfrom
bdclaw2026:bor-487-s3-studio-e2e-tests
Mar 6, 2026
Merged

BOR-487: Add E2E automation for core S3 Studio flows#20
bdclaw2026 merged 1 commit intoSTRRL:mainfrom
bdclaw2026:bor-487-s3-studio-e2e-tests

Conversation

@bdclaw2026
Copy link
Copy Markdown
Collaborator

@bdclaw2026 bdclaw2026 commented Mar 6, 2026

Summary

  • add Playwright E2E test infrastructure for apps/s3-studio
  • add real-provider env wiring for Cloudflare R2 and Supabase Storage
  • cover core UI workflow: connect, create folder, upload, rename, delete, cleanup
  • add CI workflow for E2E execution with secrets
  • document env setup and local E2E usage

Validation

  • pnpm test
  • pnpm lint

Notes

  • E2E tests run against configured providers from env (E2E_R2_*, E2E_SUPABASE_*).
  • In local validation for this branch, no provider env vars were set, so Playwright skipped provider-dependent cases by design.

Copy link
Copy Markdown

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 70bb038320

ℹ️ About Codex in GitHub

Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".

Comment on lines +45 to +50
if (providers.length === 0) {
test("skip when no E2E provider env vars are configured", async () => {
test.skip(
true,
"No provider config found. Set E2E_R2_* and/or E2E_SUPABASE_* env vars."
);
Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P2 Badge Fail CI when no E2E providers are configured

This skip branch makes the new E2E workflow report success even when no real storage tests run: if all E2E_* env vars are empty, the suite only registers a skipped test and exits cleanly. In .github/workflows/e2e.yml, those vars come from secrets, so a missing/renamed secret (or contexts without secrets) silently turns the job into a no-op instead of signaling misconfiguration, which undermines the value of this required check.

Useful? React with 👍 / 👎.

@bdclaw2026
Copy link
Copy Markdown
Collaborator Author

E2E secrets have been configured (R2). Re-running CI.

@bdclaw2026 bdclaw2026 merged commit e5b32c9 into STRRL:main Mar 6, 2026
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant