BOR-487: Add E2E automation for core S3 Studio flows#20
BOR-487: Add E2E automation for core S3 Studio flows#20bdclaw2026 merged 1 commit intoSTRRL:mainfrom
Conversation
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 70bb038320
ℹ️ About Codex in GitHub
Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".
| if (providers.length === 0) { | ||
| test("skip when no E2E provider env vars are configured", async () => { | ||
| test.skip( | ||
| true, | ||
| "No provider config found. Set E2E_R2_* and/or E2E_SUPABASE_* env vars." | ||
| ); |
There was a problem hiding this comment.
Fail CI when no E2E providers are configured
This skip branch makes the new E2E workflow report success even when no real storage tests run: if all E2E_* env vars are empty, the suite only registers a skipped test and exits cleanly. In .github/workflows/e2e.yml, those vars come from secrets, so a missing/renamed secret (or contexts without secrets) silently turns the job into a no-op instead of signaling misconfiguration, which undermines the value of this required check.
Useful? React with 👍 / 👎.
|
E2E secrets have been configured (R2). Re-running CI. |
Summary
apps/s3-studioValidation
pnpm testpnpm lintNotes
E2E_R2_*,E2E_SUPABASE_*).