fix: remove deleted schemas from dynamic routes and OpenAPI#237
Open
dcermak wants to merge 1 commit into
Open
Conversation
) Previously, when a schema was deleted, its corresponding API routes (/entity/{slug}) remained active and visible in the OpenAPI documentation until the application was restarted. This change updates the dynamic router logic to immediately remove routes associated with a deleted schema and prevents them from being registered during startup. Changes: - backend/dynamic_routes.py: Updated create_dynamic_router to skip route creation and strictly remove existing routes if schema.deleted is True - backend/general_routes.py: Updated delete_schema to inject the Request object and trigger create_dynamic_router after deletion to ensure immediate cleanup - backend/tests/test_deleted_schema_routes.py: Added regression tests ensuring routes return 404 and vanish from OpenAPI specs upon schema deletion
dcermak
force-pushed
the
remove-deleted-schemas
branch
from
a83fe09 to
d040ac4
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Previously, when a schema was deleted, its corresponding API routes (
/entity/{slug}) remained active and visible in the OpenAPI documentation until the application was restarted. This change updates the dynamic router logic to immediately remove routes associated with a deleted schema and prevents them from being registered during startup.Changes:
This fixes #236