feat: AKS: remove resource group on clean#283
Conversation
We create a resource group in AKS on deployment; for mirroring, we should also remove it when cleaning up.
viccuad
left a comment
There was a problem hiding this comment.
I'm not sure we need to remove the resource group.
From cap-terraform's readme, the resource group is a precondition for terraform, and it is personal:
https://github.com/SUSE/cap-terraform/blob/8831476c6c81758c54c162d780c5fcf039514b58/aks/README.md
This resource group will contain all resources of, and in support of your SUSE CAP cluster. Make note of the name and location which must be supplied in terraform variables.
And it seems that terraform doesn't create it either (following var https://github.com/SUSE/cap-terraform/blob/8831476c6c81758c54c162d780c5fcf039514b58/aks/variables.tf.json#L19).
So I see it as auth setup for the user, and in that case I think we should let the user decide when and how the resource group will be deleted, as it can be reused between deployments.
|
The problem was that, if we don't remove the resource group, the next deployment fails for me (because it already exists). I'll try again later to get the exact error. |
We create a resource group in AKS on deployment; for mirroring, we should also remove it when cleaning up.