Sourcery refactored master branch

BFS/python/bfs.py

@@ -10,19 +10,18 @@ def addEdge(self, u, v):
         self.graph[u].append(v)
 
     def BFS(self, node):
-        queue = []
-        queue.append(node)
+        queue = [node]
         self.visited[node] = True
 
         while queue:
             currentNode = queue.pop(0)
             print(currentNode)
 
             children = self.graph[currentNode]
-            for i in range(len(children)):
-                if not self.visited[children[i]]:
-                    queue.append(children[i])
-                    self.visited[children[i]] = True
+            for child in children:
+                if not self.visited[child]:
+                    queue.append(child)
+                    self.visited[child] = True
 
 
 if __name__ == '__main__':

BST/python/BinarySearchTree.py

@@ -23,69 +23,71 @@ def isEmpty(self):
         return self._size == 0
 
     def populateTree(self):
-        for i in range(len(self.arr)):
-            self.insert(self.arr[i])
+        for item in self.arr:
+            self.insert(item)
 
     def insert(self, value):
-        if type(value) == self._dataType:
-            itemNum = self._size
-            newNode = Node(value, type(value), itemNum, None, None, None)
-            if (self._root is None):
-                self._root = newNode
-                self._size += 1
-                return
+        if type(value) != self._dataType:
+            return
+        itemNum = self._size
+        newNode = Node(value, type(value), itemNum, None, None, None)
+        if (self._root is None):
+            self._root = newNode
+            self._size += 1
+            return
+
+        pointer = self._root
+        currentVal = pointer.getData()
+        while True:
+            if value < currentVal:
+                if pointer.getLeft() is None:
+                    newNode.setParent(pointer)
+                    pointer.setLeft(newNode)
+                    self._size += 1
+                    return
+                else:
+                    pointer = pointer.getLeft()
+                    currentVal = pointer.getData()
 
-            pointer = self._root
-            currentVal = pointer.getData()
-            while True:
-                if value < currentVal:
-                    if pointer.getLeft() is None:
-                        newNode.setParent(pointer)
-                        pointer.setLeft(newNode)
-                        self._size += 1
-                        return
-                    else:
-                        pointer = pointer.getLeft()
-                        currentVal = pointer.getData()
-
-                elif value > currentVal:
-                    if pointer.getRight() is None:
-                        newNode.setParent(pointer)
-                        pointer.setRight(newNode)
-                        self._size += 1
-                        return
-                    else:
-                        pointer = pointer.getRight()
-                        currentVal = pointer.getData()
-
-                elif value == currentVal:
-                    print("Value already exists in BST.")
+            elif value > currentVal:
+                if pointer.getRight() is None:
+                    newNode.setParent(pointer)
+                    pointer.setRight(newNode)
+                    self._size += 1
                     return
+                else:
+                    pointer = pointer.getRight()
+                    currentVal = pointer.getData()
+
+            elif value == currentVal:
+                print("Value already exists in BST.")
+                return
 
     def search(self, value):
-        if type(value) == self._dataType:
-            if (self._root is None):
-                return False
+        if type(value) != self._dataType:
+            return
+        if (self._root is None):
+            return False
 
-            pointer = self._root
-            currentVal = pointer.getData()
-            while True:
-                if value < currentVal:
-                    if pointer.getLeft() is None:
-                        return False
+        pointer = self._root
+        currentVal = pointer.getData()
+        while True:
+            if value < currentVal:
+                if pointer.getLeft() is None:
+                    return False
 
-                    pointer = pointer.getLeft()
-                    currentVal = pointer.getData()
+                pointer = pointer.getLeft()
+                currentVal = pointer.getData()
 
-                elif value > currentVal:
-                    if pointer.getRight() is None:
-                        return False
+            elif value > currentVal:
+                if pointer.getRight() is None:
+                    return False
 
-                    pointer = pointer.getRight()
-                    currentVal = pointer.getData()
+                pointer = pointer.getRight()
+                currentVal = pointer.getData()
 
-                elif value == currentVal:
-                    return pointer.getItemNum()
+            elif value == currentVal:
+                return pointer.getItemNum()
 
     def inOrderTraversal(self, node):
         if node is not None:
@@ -94,7 +96,7 @@ def inOrderTraversal(self, node):
             self.inOrderTraversal(node.getRight())
 
     def getSorted(self):
-        self.sorted = list()
+        self.sorted = []
         self.inOrderTraversal(self._root)
         return self.sorted
 

BackTracking/Hamilton Path/hamilton.py

@@ -20,15 +20,11 @@ def isSafe(self, v, pos, path):
     def hamCycleUtil(self, path, pos):
 
         # base case: if all vertices are
-        # included in the path
+            # included in the path
         if pos == self.V:
             # Last vertex must be adjacent to the
-            # first vertex in path to make a cyle
-            if self.graph[path[pos - 1]][path[0]] == 1:
-                return True
-            else:
-                return False
-
+                    # first vertex in path to make a cyle
+            return self.graph[path[pos - 1]][path[0]] == 1
         for v in range(1, self.V):
 
             if self.isSafe(v, pos, path) is True:

BackTracking/RatInAMaze/ratmaze.py

@@ -16,9 +16,7 @@ def printSolution(sol):
 # A utility function to check if x,y is valid
 # index for N*N Maze
 def isSafe(maze, x, y):
-    if x >= 0 and x < N and y >= 0 and y < N and maze[x][y] == 1:
-        return True
-    return False
+    return x >= 0 and x < N and y >= 0 and y < N and maze[x][y] == 1
 
 
 def solveMaze(maze):

BitManipulation/count_ones/count_ones.py

@@ -3,7 +3,7 @@ def count_ones(n: int):
     while n:
         if n & 1:
             count += 1
-        n = n // 2
+        n //= 2
     return count
 
 

DP/Fibonacci/fibonacci.py

@@ -1,6 +1,6 @@
 # DP Approach for Fibonacci series
 
-ans = dict()
+ans = {}
 
 
 def fibo(i):

Graph/DijkstrasSPT/python/Dadjacencylist.py

@@ -11,8 +11,7 @@ def __init__(self):
         self.pos = []
 
     def newMinHeapNode(self, v, dist):
-        minHeapNode = [v, dist]
-        return minHeapNode
+        return [v, dist]
 
     # A utility function to swap two nodes
     # of min heap. Needed for min heapify
@@ -82,9 +81,7 @@ def decreaseKey(self, v, dist):
     # vertex 'v' is in min heap or not
     def isInMinHeap(self, v):
 
-        if self.pos[v] < self.size:
-            return True
-        return False
+        return self.pos[v] < self.size
 
 
 def printArr(dist, n):

Hashing/3_Sum/threeSum.py

@@ -2,13 +2,14 @@
 Author: Tushar Nitave
 '''
 
+
 nums = [-1, 0, 1, 2, -1, -4]
 
 hashTable = []
 result = []  # result containing duplicate values
 finalresult = []  # stores final result without duplicate values
 
-for i in range(0, len(nums) - 2):
+for i in range(len(nums) - 2):
 
     for j in range(i + 1, len(nums) - 1):
         x = -(nums[i] + nums[j])
@@ -20,9 +21,9 @@
         else:
             hashTable.append(nums[j])
 
-for i in range(len(result)):
-    result[i].sort()
-    if not result[i] in finalresult:
-        finalresult.append(result[i])
+for item in result:
+    item.sort()
+    if item not in finalresult:
+        finalresult.append(item)
 
 print(finalresult)

Math/Prime/python/prime.py

@@ -5,10 +5,7 @@
 def is_prime(number):
     if (number <= 1):
         return False
-    for i in range(2, 1 + int(math.sqrt(number))):
-        if (number % i) == 0:
-            return False
-    return True
+    return all(number % i != 0 for i in range(2, 1 + int(math.sqrt(number))))
 
 number = input("Enter a number : ")
 

Math/Russain Peasants Algorithm/python/russian-peasants-algorithm.py

@@ -6,13 +6,13 @@ def multiply(a,b):
     else:
         left = b
         right = a
-    
+
     prod = 0
-    
+
     while left > 0: # Loop till you reach 1
         if left%2 != 0:  # Add the value to product variable if the left column value is odd
-            prod = prod + right
-        
+            prod += right
+
         left = left >> 1 # Right shift
         right = right << 1 # Left Shift
 

Math/collatz_conjecture/Python/collatz_conjecture.py

@@ -1,12 +1,8 @@
 def collatz(n):
     seq = [n]
     while n > 1:
-        if n%2 == 1:
-            n = n*3 + 1
-            seq.append(n)
-        else:
-            n = n/2
-            seq.append(n)
+        n = n * 3 + 1 if n % 2 == 1 else n / 2
+        seq.append(n)
     return seq
 
 if __name__ == "__main__" :

Math/eulers_totient_function/python/eulers_totient.py

@@ -5,10 +5,4 @@ def gcd(a, b):
 	return gcd(b % a, a)
 
 def phi(n):
-	res = 1
-
-	for i in range(2, n):
-		if gcd(i, n) == 1:
-			res += 1
-
-	return res
+	return 1 + sum(1 for i in range(2, n) if gcd(i, n) == 1)

Math/lowest_common_multiple/lcm.py

@@ -1,11 +1,11 @@
-def lcm(num1, num2):
-    """Returns the lowest common multiple of two given integers."""
-    temp_num = num1
-    while (temp_num % num2) != 0:
-        temp_num += num1
-    return temp_num
-	
-if __name__ == "__main__":
-    print lcm(3, 9) # output is 9
-    print lcm(24, 36) # output is 72
-    print lcm(12, 80) # output is 240
+def lcm(num1, num2):
+    """Returns the lowest common multiple of two given integers."""
+    temp_num = num1
+    while (temp_num % num2) != 0:
+        temp_num += num1
+    return temp_num
+
+if __name__ == "__main__":
+    print lcm(3, 9) # output is 9
+    print lcm(24, 36) # output is 72
+    print lcm(12, 80) # output is 240

NetworkFlow/EdmundKarp/edmund_karp.py

@@ -16,12 +16,11 @@ def EdmondsKarp(E, C, s, t):
         P[s] = -2
         M = [0 for x in range(n)]
         M[s] = decimal.Decimal('Infinity')
-        BFSq = []
-        BFSq.append(s)
+        BFSq = [s]
         pathFlow, P = BFSEK(E, C, s, t, F, P, M, BFSq)
         if pathFlow == 0:
             break
-        flow = flow + pathFlow
+        flow += pathFlow
         v = t
         while v != s:
             u = P[v]

Search/FibonacciSearch/fibonacci_search.py

@@ -44,9 +44,7 @@ def fibonacci_search(arr, x, n):
 if __name__ == "__main__":
     n = int(input("Enter the number of elements: "))
     print("Enter the elements each line")
-    arr = []
-    for i in range(n):
-        arr.append(int(input()))
+    arr = [int(input()) for _ in range(n)]
     x = int(input("Enter element to be searched: "))
     idx = fibonacci_search(arr, x, n)
     if idx == -1:

Search/LinearSearch/linear_search.py

@@ -4,11 +4,9 @@
 @author: KARAN
 """
 
-numbers = []
-n = int(input("Enter the total number of elements :  "))
-for i in range(n):
-    numbers.append(int(input("Enter a number : ")))
 
+n = int(input("Enter the total number of elements :  "))
+numbers = [int(input("Enter a number : ")) for _ in range(n)]
 key = int(input("Enter the number you wanna find in the list : "))
 found = False
 for i in range(n):

Search/hashing/2_Sum/sum_pair.py

@@ -1,11 +1,11 @@
 def print_pairs(arr, sum):
   s = set()
 
-  for i in range(0, len(arr)):
-    temp = sum - arr[i]
+  for item in arr:
+    temp = sum - item
     if temp >= 0 and temp in s:
-      print("Pair with the given sum is", arr[i], "and", temp)
-    s.add(arr[i])
+      print("Pair with the given sum is", item, "and", temp)
+    s.add(item)
 
 
 if __name__ == "__main__":