7주차 미션 [레인]#21
Open
geumbiii wants to merge 1 commit into
Open
Conversation
ywkim1m
reviewed
May 19, 2026
| condition, | ||
| rewardPoint, | ||
| }); | ||
| res.status(201).json(success(result)); |
Collaborator
There was a problem hiding this comment.
.json() 직접 호출 대신 Promise<ApiResponse<...>> 반환 방식으로 통일하면 좋을 것 같습니다!
ywkim1m
approved these changes
May 19, 2026
Collaborator
ywkim1m
left a comment
ywkim1m
left a comment
There was a problem hiding this comment.
타 컨트롤러도 mission 컨트롤러와 같이 응답 방식을 통일하면 좋을 것 같습니다!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
7주차 미션
Error객체를 선언해 던지도록 리팩토링npm install하고app.use()로 적용코드 첨부 완료