fix(notifications): route push transports by explicit provider#1273
Merged
Conversation
eleboucher
force-pushed
the
fix/push-transport-switch
branch
5 times, most recently
from
July 24, 2026 10:44
1a1ca63 to
d60c6dd
Compare
eleboucher
force-pushed
the
fix/push-transport-switch
branch
from
July 24, 2026 10:47
d60c6dd to
014c4eb
Compare
eleboucher
marked this pull request as draft
July 24, 2026 15:34
eleboucher
marked this pull request as ready for review
July 24, 2026 21:08
7w1
approved these changes
Jul 24, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Fixes several Android push-notification bugs, and bumps
tauri-plugin-notificationsto pick up the matching native fixes (SableClient/tauri-plugin-notifications#11).Transport routing
provider: 'fcm'/provider: 'unifiedpush'explicitly on register, so the plugin routes deterministically instead of inferring from saved state (switching to native no longer keeps using the old UnifiedPush distributor).switchBackgroundPushTransportis break-before-make (deactivate old → register new), which the plugin's single-active-provider guard requires. If the new registration fails, the previous transport is now restored instead of leaving the device with no pusher while the UI still says push is on.enablePushNotificationsno-ops under Tauri instead of throwing (fixes the SABLE-162 unhandled rejection).Background notification previews
isEncryptedRoomis derived from the local room, which is absent on a cold start from push, so the gate passed and the decrypted body was shown. Encryption is now taken from the fetched event itself.Type of change
Checklist:
AI disclosure: