fix(sticker): send using the pack's image info instead of downloading the sticker#1332
Open
eleboucher wants to merge 1 commit into
Open
fix(sticker): send using the pack's image info instead of downloading the sticker#1332eleboucher wants to merge 1 commit into
eleboucher wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Tapping a sticker did nothing. The send path downloaded and decoded the sticker purely to compute
info, with no error handling, so any media failure meantsendEventwas never reached. It now uses theinfothe pack already declares, only measures the file when a pack omits it, and sends either way.Fixes #1323
Type of change
Checklist:
AI disclosure: