fix(media): request our own video and audio with CORS so Firefox does not block it#1334
Open
eleboucher wants to merge 1 commit into
Open
fix(media): request our own video and audio with CORS so Firefox does not block it#1334eleboucher wants to merge 1 commit into
eleboucher wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Firefox blocks media Range responses whose URL it has not already sniffed as audio/video (mozilla bug 1880289), which homeservers serving
application/octet-streamtrip. The element then reports "no video with supported format and MIME type found" and the request shows asNS_BINDING_ABORTED. Requesting with CORS opts out of ORB.Only applied to our own media, since external
og:videoURLs from link previews go through the same component and cannot be assumed to sendAccess-Control-Allow-Origin.Verified on firefox
Fixes #
Type of change
Checklist:
AI disclosure: