Fix OIDC logins silently failing when switching accounts#882
Merged
dozro merged 2 commits intoMay 20, 2026
Conversation
…oring login attempts The router only lets you visit `/home` or the like if `addAccount` is unset, but this did not account for `loginToken`. Now, if `loginToken` is set, you visit the `/login/server` route instead of being redirected to `/home`, allowing the account switcher to work as intended.
770grappenmaker
changed the title
Contributor
Author
|
Perhaps an additional check should be done whether this concerns the |
Member
|
Hi, thank you so much for your contribution, could you please also add a .md file in the .changeset folder so that, if merged it will attribute the fix to you? the file should be of the form (inside ---
default: patch
---
Fix Account Switching and Multiple Sign-insor the like |
dozro
approved these changes
May 20, 2026
Member
dozro
left a comment
dozro
left a comment
There was a problem hiding this comment.
looks good to me, tested it, solves the issue apparently
tested with:
matrix.orgfairchat.eu
(signed in at the same time)
11 tasks
7w1
approved these changes
May 20, 2026
ProfessorVarox
pushed a commit
to ProfessorVarox/sable
that referenced
this pull request
May 22, 2026
> [!IMPORTANT] > Merging this PR will create a new release. ## Features * Add support for misskey-flavored markdown color definitions. E.g. `$[fg.color=f00 bg.color=00ff00 red on green]`. ([SableClient#860](<SableClient#860>) by @7w1) * Add per Space setting for when to show room icons in sidebar ([SableClient#851](<SableClient#851>) by @nushea) * Add toggle to list all rooms inside of the home sidebar. ([SableClient#866](<SableClient#866>) by @nushea) ### Change Image Viewer to feel more natural to use. ([SableClient#686](<SableClient#686>) by @7w1, @nushea, @Septicity) - Fixed zoom gestures generally not working on mobile. - Changed the % number in the top right to reflect the zoom of the original image as opposed to the change from it fitting the container. - Made the zoom pill allow entering custom values. - Added a button that zooms you to the original size of the image, and a button to return to the size that fills the container. - Added a pixelated image scaling setting: choose Both, Chat, Image viewer (default), or Neither for crisp nearest-neighbor rendering. - Transitions are now disabled for manual panning to improve responsiveness. ## Fixes * Fixed starting lists at arbitrary numbers and list markers extending off screen with long numbers. ([SableClient#860](<SableClient#860>) by @7w1) * Fix single new lines after block quotes being block-quoted. ([SableClient#860](<SableClient#860>) by @7w1) * Fix emojis not rendering in reply chips. ([SableClient#860](<SableClient#860>) by @7w1) * Hardened html parsing in standard input box, should no longer randomly delete text in arrow brackets (unless valid, properly closed, legal html). ([SableClient#860](<SableClient#860>) by @7w1) * Fixed the message loading spinner flickering instead of continuing during large pagination chunks. ([SableClient#895](<SableClient#895>) by @7w1) * Fix matrix.to links getting arrow brackets inserted when editing messages. ([SableClient#860](<SableClient#860>) by @7w1) * Fix mentions breaking after editing messages with mentions. ([SableClient#860](<SableClient#860>) by @7w1) * Fix account switching and logging in with multiple (SSO) accounts silently failing ([SableClient#882](<SableClient#882>) by @770grappenmaker) * Removed the arbitrary bio limit from the bio editor. ([SableClient#863](<SableClient#863>) by @7w1) * Remove target and rel attributes from outgoing html links. ([SableClient#891](<SableClient#891>) by @7w1) * Fix tablet layouts having the sidebar fill up the screen. ([SableClient#864](<SableClient#864>) by @7w1) * Add support for stable mutual rooms endpoint, manually ported from [this commit](cinnyapp/cinny@bef2672) by ajbura upstream. ([SableClient#852](<SableClient#852>) by @7w1) ## Documentation * Docker build tags have been updated: `latest` now tracks the latest versioned release and `dev` now tracks the dev branch. ([SableClient#892](<SableClient#892>) by @7w1)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix OIDC logins in the account switcher failing due to the router ignoring login attempts. Closes #40 and probably more related issues.
Description
The router only lets you visit
/homeor the like ifaddAccountis unset, but this did not account forloginToken. Now, ifloginTokenis set, you visit the/login/serverroute instead of being redirected to/home, allowing the account switcher to work as intended.Fixes #40
Fixes #284
Type of change
Checklist:
AI disclosure:
No AI assists.