Skip to content

fix(android): attach room payload to cold-start push notification intent#6

Merged
eleboucher merged 1 commit into
SableClient:mainfrom
eleboucher:fix/cold-start-notification-payload
Jul 20, 2026
Merged

fix(android): attach room payload to cold-start push notification intent#6
eleboucher merged 1 commit into
SableClient:mainfrom
eleboucher:fix/cold-start-notification-payload

Conversation

@eleboucher

Copy link
Copy Markdown
Collaborator

UnifiedPushNotifier.showFromPush() built a bare launch PendingIntent with no room_id/event_id/user_id, so cold-start notification taps opened the app to the home screen with zero room context. Attach the push payload to the intent so NotificationPlugin.onIntent() can extract and emit it to JS via triggerNotificationClicked(), matching the warm-path behavior.

UnifiedPushNotifier.showFromPush() built a bare launch PendingIntent with no
room_id/event_id/user_id, so cold-start notification taps opened the app to
the home screen with zero room context. Attach the push payload to the
intent so NotificationPlugin.onIntent() can extract and emit it to JS via
triggerNotificationClicked(), matching the warm-path behavior.
@codecov-commenter

codecov-commenter commented Jul 20, 2026

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 0% with 32 lines in your changes missing coverage. Please review.

Files with missing lines Patch % Lines
...java/app/tauri/notification/UnifiedPushNotifier.kt 0.00% 32 Missing ⚠️

📢 Thoughts on this report? Let us know!

@eleboucher
eleboucher merged commit 4ea297b into SableClient:main Jul 20, 2026
21 checks passed
@eleboucher
eleboucher deleted the fix/cold-start-notification-payload branch July 20, 2026 15:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants