Fix CodeQL code scanning workflow (pack resolution and triggers)#9
Open
danbaruka wants to merge 2 commits intoSafrochain-Org:mainfrom
Open
Fix CodeQL code scanning workflow (pack resolution and triggers)#9danbaruka wants to merge 2 commits intoSafrochain-Org:mainfrom
danbaruka wants to merge 2 commits intoSafrochain-Org:mainfrom
Conversation
… streamlining project resources.
- Drop crypto-com/cosmos-sdk-codeql pack (pins obsolete codeql/go-all 0.3.6) - Trigger on workflow, CodeQL config, go.mod/sum, and Makefile changes - Add workflow_dispatch for manual runs - Use codeql-action v4 for init/analyze Made-with: Cursor
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Resolves GitHub Code scanning configuration errors caused by an incompatible third-party CodeQL pack, and makes CodeQL run when relevant repo metadata changes—not only when
*.gofiles change.Problem
crypto-com/cosmos-sdk-codeql, which depends oncodeql/go-all: 0.3.6. That pin is far behind thecodeql/go-allversion bundled with current GitHub Code Scanning, so pack resolution fails and the Security tab shows configuration errors.**.go, so updates togo.mod,Makefile, or the CodeQL workflow itself did not re-run analysis—leading to stale “last scanned” messaging.Changes
packs: +crypto-com/cosmos-sdk-codeqlfrom the CodeQL init step.pathsfilters onpull_requestandpushto includego.mod,go.sum,Makefile,.github/workflows/codeql.yml, and.github/codeql/**.workflow_dispatchso maintainers can run CodeQL manually from the Actions tab.github/codeql-action/initandanalyzefrom v3 → v4.What stays the same
.github/codeql/codeql-config.ymlsecurity-and-qualityplus the same experimental Go queries fromgithub/codeql(DeferInLoop,WrongUsageOfUnsafe,DivideByZero).Follow-ups (optional)
codeql/go-allcompatible with today’s CodeQL—not the unmaintained crypto-com pack as-is.