add support for bunyan style log method: log.info({foo: 'bar'}, 'hi');#2
add support for bunyan style log method: log.info({foo: 'bar'}, 'hi');#2complyue wants to merge 4 commits intoSagacify:masterfrom
Conversation
Conform status to
Conform status to
Conform status to
Conform status to |
|
any hint? seems commit messages are constrained by some format, what's the format? |
|
Indeed, we like to standardize our commit message format and use an agent for that at Sagacify. Don't worry about that here though, I will review your commit and merge it if it seems ok. That being said, if you would like to comply with our commit message structure, the SagaStalin agent shows you the structure in its comments. Thanks for your contribution |
|
Okay, so I understand Stalin just mandatory BTW I'm now struggling to have bunyan log print well in PyCharm, I know you may not be using PyCharm, but I'd like to hear any ideas. Pls have a look at my SO question if you have time: http://stackoverflow.com/questions/38708246/ |
|
Hey, sorry I'm on holiday right now so I won't have time to look at the code until next week. Don't hesitate to ping me if I forget. Regarding the commit message formatting, all repos in our organisation follow the semantic release commit message formatting. This means one of the following as commit type: fix feat(feature) test doc and I can't remember the rest. Also the name python Bunyan is a bit of a lie. We started from an old package no longer maintained but we are actually copying the behaviour of our other loggers. Sagacity/logger and Sagacify/scala-logger. That said, I'll have a look at your patch next week. |
I'd like to continue using one of node-bunyan's log method style, but not working correctly in latest python-bunyan:
For
logger.info({'foo': 'bar'}, 'hi');expected:
{"name": "__main__", "foo": "bar", "msg": "hi", "time": "2016-08-02T03:37:28Z", "hostname": "cymp.local", "level": 30, "pid": 8643, "v": 0}but msg is empty:
{"name": "__main__", "foo": "bar", "msg": "", "time": "2016-08-02T03:41:38Z", "hostname": "cymp.local", "level": 30, "pid": 10003, "v": 0}And I updated the code for it to work as expected.
So far
nosetests testspassed for 3.5.2/2.7