[SYNPY-1783] Implemented grid synchronization #1368
Open
Conversation
BryanFauble
reviewed
May 6, 2026
BryanFauble
approved these changes
May 6, 2026
Member
BryanFauble
left a comment
BryanFauble
left a comment
There was a problem hiding this comment.
Logic on this looks good to me, check in on tests/integration/synapseclient/models/async/test_curation_async.py and the removal of some code there.
andrewelamb
requested changes
May 7, 2026
| """ | ||
|
|
||
| session_id: str = "" | ||
| """The ID of the grid session to synchronize.""" |
Contributor
There was a problem hiding this comment.
This seems like it should be required, why have a default value? Should we call this grid_session_id to be consistent with the endpoint?
Contributor
|
@linglp Looks good overall, I found a few things to fix. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem:
grid can't be sync using the python client
Solution:
grid created by file view can be sync
Test
See validation instructions: https://sagebionetworks.jira.com/browse/SYNPY-1783?focusedCommentId=322977