Skip to content

Fix: schedule_for_cleanup was not called correctly in test_wiki #1369

Draft
linglp wants to merge 6 commits intodevelopfrom
fix-wiki-attachment-cleanup
Draft

Fix: schedule_for_cleanup was not called correctly in test_wiki #1369
linglp wants to merge 6 commits intodevelopfrom
fix-wiki-attachment-cleanup

Conversation

@linglp
Copy link
Copy Markdown
Contributor

@linglp linglp commented Apr 24, 2026

Problem:

I saw this in the Github action run log:

Don't know how to clean: 842124 (type: str)Don't know how to clean: /var/folders/4b/2nnnxx0n2f15srrx6d6ndm7c0000gn/T/tmpmoqiepqs.txt.gz (type: str)Don't know how to clean: https://data.dev.sagebase.org/3705170/65689ca5-6896-4ba1-830d-24c28664fcac/cb646f7f-b828-4ba3-bc78-30edc99bc270?response-content-disposition=attachment%3B%20filename%3D%22preview.txt%22%3B%20filename%2A%3Dutf-8%27%27preview.txt&response-content-type=text%2Fplain&X-Amz-Date=20260424T165655Z&X-Amz-Expires=900&Expires=1777050715&Signature=pq2nTTUMFMCY2bfATv81NBZj8ohyiB-r-noooMYdfdo3xqfAR2nsPY5dRtssYOLOpQ6L0ymkELSqAIXIHg60NYbQEgCAfCGO0VdWgVOcdWewI-6aWq18vGs-h6DJc0t8Z3LH4mhvAFKquZC1dJgylZS5DBchID1rHCl9ULH6qEOu-2lhq0dyzVXMCsU7bgD-ig3g2gYHbbVODTcHwwLytRZvhWJbyNhpk2ZEH5EMNNK3CVEUzfsHXWHvVOyA9k3cbLEAWbKl5844YHf00qtMxiTTuzLvgImmH9G-8n70ftY90GB0SI35Nn9M4YipVSVW~DD6HBC7lHauBef0isu9iA__&Key-Pair-Id=K3YW7HKX09P9M (type: str)Don't know how to clean: 842123 (type: str)Don't know how to clean: /var/folders/4b/2nnnxx0n2f15srrx6d6ndm7c0000gn/T/tmpoo6gu587.txt.gz (type: str)Don't know how to clean: 842122 (type: str)Don't know how to clean: /var/folders/4b/2nnnxx0n2f15srrx6d6ndm7c0000gn/T/tmp2k60nzgx.txt.gz (type: str)Don't know how to clean: https://data.dev.sagebase.org/3705170/e271a957-93bd-4f77-ad3f-b2f3e95931c4/tmp973cxksh.txt.gz?response-content-disposition=attachment%3B%20filename%3D%22tmp973cxksh.txt.gz%22%3B%20filename%2A%3Dutf-8%27%27tmp973cxksh.txt.gz&response-content-type=text%2Fplain&X-Amz-Date=20260424T165642Z&X-Amz-Expires=900&Expires=1777050702&Signature=DWnTcTngKtCO1~GdY7jlF~Zmwv16okQQ2hjaSA-oYk3r9dgDdrDp~vem90E7REjf6VmrZYUu1htEYeB-Y01Sp4T9-5lytb0Cjx5ny2lvY~ZWlbS6X1kk0BY1vZ56-10nfO7ZTNNzdrUp~R6d2SKrB9vT7dJC8N8uYDRzaTmld9k~qLFtZsWEBWKKPVB4yWswxtZQGvNVTATMFxA3pDePR2wMBL3FRKA16IZDHBlAnPssnWEqYelmqfXtuTK-ybM0NVJkx3Pyr0e3nA-~byBi63hbuaG5oK7Ch2JAAAvDtYfKy-tZ9P3e2oW2LfiW~CctWyN~w0sfCtC6le~53MbjpA__&Key-Pair-Id=K3YW7HKX09P9M (type: str)Don't know how to clean: 842121 (type: str)Don't know how to clean: /var/folders/4b/2nnnxx0n2f15srrx6d6ndm7c0000gn/T/tmp973cxksh.txt.gz (type: str)Don't know how to clean: {'list': [{'id': '15915476', 'etag': 'cd2b7f11-fd7e-42fb-bb44-ec5d808a397a', 'createdBy': '3705170', 'createdOn': '2026-04-24T16:56:38.000Z', 'modifiedOn': '2026-04-24T16:56:39.000Z', 'concreteType': 'org.sagebionetworks.repo.model.file.S3FileHandle', 'contentType': 'text/plain', 'contentMd5': 'b73e9cd5b360af5a1581daa468e7e86b', 'fileName': 'tmpc8anir7e.txt.gz', 'storageLocationId': 1, 'contentSize': 54, 'status': 'AVAILABLE', 'bucketName': 'devdata.sagebase.org', 'key': '3705170/57b94ab9-926c-4505-b29f-3956eb019db0/tmpc8anir7e.txt.gz', 'isPreview': False}]} (type: dict)Don't know how to clean: 842119 (type: str)Don't know how to clean: /var/folders/4b/2nnnxx0n2f15srrx6d6ndm7c0000gn/T/tmpc8anir7e.txt.gz (type: str)Don't know how to clean: 842113 (type: str)Don't know how to clean: https://data.dev.sagebase.org/3705170/8989e135-709d-428f-9390-3cf8502c7396/cf02bac7-be5c-4cd4-b06e-490446bd470b?response-content-disposition=attachment%3B%20filename%3D%22preview.txt%22%3B%20filename%2A%3Dutf-8%27%27preview.txt&response-content-type=text%2Fplain&X-Amz-Date=20260424T165625Z&X-Amz-Expires=900&Expires=1777050685&Signature=ZPy949vzQF7I~eliiKolI96JY20gm~chDCYLCTV6cyd8Gxo4FTYVnJ0EAXcOjHiN5C4htK7wH720qVNyy-Ehkjz2lX0CVnYkpgxfKszu5FS2Zk7-sWXJA0xynduMTIIwSPyJl6XNwkOWVD4Mm2ln8bX1jRwUntL45PNEFhEDBmd0EWa7esGt~cCuy12zMM2EHkTr2Nq39lzAu9IeaKjUGsgk9SPaxwacDJrSMXLGGbFiPaPyPQdKjXmX1glOBNdAN9RpteacWVvszRueuB6Q9S-uYh-SzOB2yCdEzkwvrqRJ~nXp3yB5CwjGi71QF9aLPxAM6IRT1wVPy47Z0rA0iA__&Key-Pair-Id=K3YW7HKX09P9M (type: str)Don't know how to clean: 842112 (type: str)Don't know how to clean: 842111 (type: str)Don't know how to clean: https://data.dev.sagebase.org/3705170/f57f976d-e7db-46da-b863-9cc8fe820766/tmpzo077i81.txt.gz?response-content-disposition=attachment%3B%20filename%3D%22tmpzo077i81.txt.gz%22%3B%20filename%2A%3Dutf-8%27%27tmpzo077i81.txt.gz&response-content-type=text%2Fplain&X-Amz-Date=20260424T165554Z&X-Amz-Expires=900&Expires=1777050654&Signature=nE57GNN8CdIBuajtlEwPGbEv3TRLft6iksdBSYmP0~iU2DYNQGII4iNrpJ9PMIBVaddWKvfIbW-rz8RC9TznGSngnHXpL8sZIGYPVKoJDwsy7jb7F2cKd3BN3JYx0ZhNeJLEtpolWXd~KKmqwQwqHYA0AaBLfYe9C1rtyOIulqxF8UJVA-NwkDr4py9uQ14dtQYvRQ9snrobscMnER817752cg2~lwE5gBweXSd~VMRnuZpnaK7ov5AEZkcwrgIhjfEjnWLjBExE-ZaqZCtbyUyGPX9XhLaxFhvsCqV0wnJJWRhTUbuIGn9PJEJQtWGXXhQjOIwmCliqitw68l1~~g__&Key-Pair-Id=K3YW7HKX09P9M (type: str)Don't know how to clean: 842110 (type: str)Don't know how to clean: {'list': [{'id': '15915281', 'etag': '82227281-8cb1-4f90-9098-b0f4d6db2ea3', 'createdBy': '3705170', 'createdOn': '2026-04-24T16:55:50.000Z', 'modifiedOn': '2026-04-24T16:55:50.000Z', 'concreteType': 'org.sagebionetworks.repo.model.file.S3FileHandle', 'contentType': 'text/plain', 'contentMd5': '9dcefc25863c7921fc376fc2cc7618b9', 'fileName': 'tmpnqy28yei.txt.gz', 'storageLocationId': 1, 'contentSize': 73, 'status': 'AVAILABLE', 'bucketName': 'devdata.sagebase.org', 'key': '3705170/6ec6478c-fcfc-49d5-a779-5466600df7d4/tmpnqy28yei.txt.gz', 'isPreview': False}]} (type: dict)Don't know how to clean: 842109 (type: str)

Solution:

schedule_for_cleanup was not called correctly in test_wiki

  • wiki page .id is a numeric string (e.g. "640372"), not a syn-prefixed Synapse ID.
  • temporary files and directories are automatically managed. No need to clean them up

Below can't be cleaned up:

What Why
schedule_for_cleanup(attachment_handles) dict — no cleanup method
schedule_for_cleanup(attachment_url) / schedule_for_cleanup(markdown_url) / schedule_for_cleanup(preview_url) Pre-signed URL strings — not local paths, not Synapse entities
schedule_for_cleanup(history) list[WikiHistorySnapshot] — no delete_async
schedule_for_cleanup(headers) list[WikiHeader] — no delete_async
schedule_for_cleanup(order_hint) / updated_order_hint / retrieved_order_hint WikiOrderHint — no delete_async

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant