Skip to content

Add missing MY_PROXY_SECRET_KEY variable in tutorials#1375

Merged
rxu17 merged 9 commits intodevelopfrom
update_proxy_server_tutorial
May 7, 2026
Merged

Add missing MY_PROXY_SECRET_KEY variable in tutorials#1375
rxu17 merged 9 commits intodevelopfrom
update_proxy_server_tutorial

Conversation

@rxu17
Copy link
Copy Markdown
Contributor

@rxu17 rxu17 commented May 6, 2026

Problem:

The proxy storage location tutorial and storage location tutorials (proxy storage section) were missing the definition for the MY_PROXY_SECRET_KEY variable prior to calling it later in StorageLocation

Solution:

This PR adds the missing variable to the tutorials

Testing:

mkdocs serve result

Proxy storage location tutorial
image

Storage locations tutorial
image

Copilot AI review requested due to automatic review settings May 6, 2026 23:31
@rxu17 rxu17 requested a review from a team as a code owner May 6, 2026 23:31
Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR updates the Python tutorial scripts used by the docs so the proxy storage location examples define MY_PROXY_SECRET_KEY before it’s referenced when constructing a StorageLocation.

Changes:

  • Add a MY_PROXY_SECRET_KEY constant to the proxy storage location tutorial script.
  • Fix the storage location tutorial script to define and pass MY_PROXY_SECRET_KEY to StorageLocation(secret_key=...).

Reviewed changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated 2 comments.

File Description
docs/tutorials/python/tutorial_scripts/storage_location.py Defines MY_PROXY_SECRET_KEY and uses it when creating a PROXY StorageLocation.
docs/tutorials/python/tutorial_scripts/proxy_storage_location.py Adds the missing MY_PROXY_SECRET_KEY constant used by the proxy storage location example.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Comment thread docs/tutorials/python/tutorial_scripts/storage_location.py
Comment thread docs/tutorials/python/tutorial_scripts/proxy_storage_location.py Outdated
Copy link
Copy Markdown
Contributor

@linglp linglp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!!

Comment thread docs/tutorials/python/tutorial_scripts/proxy_storage_location.py Outdated
Comment thread docs/tutorials/python/tutorial_scripts/storage_location.py Outdated
Comment thread docs/tutorials/python/tutorial_scripts/proxy_storage_location.py
@rxu17 rxu17 merged commit 3122476 into develop May 7, 2026
57 of 58 checks passed
@rxu17 rxu17 deleted the update_proxy_server_tutorial branch May 7, 2026 22:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants