[SYNPY-1832] Fix bug causing RecordSet to be updated to v2#1378
Open
andrewelamb wants to merge 2 commits intodevelopfrom
Open
[SYNPY-1832] Fix bug causing RecordSet to be updated to v2#1378andrewelamb wants to merge 2 commits intodevelopfrom
andrewelamb wants to merge 2 commits intodevelopfrom
Conversation
andrewelamb
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem:
The
create_record_based_metadata_taskfunction was needlessly updating the RecordSet version it created.Solution:
The line of code that was updating the RecordSet was removed.
Testing:
An integration test for
create_record_based_metadata_taskwas added that tests that the version of the createdRecordSetis now 1.Unit tests were fixed that were expecting
grid.export_to_record_setto be called