varbin: Fix handle private field by accident#95
Conversation
|
Another bug:
Furthermore, stripping the pointer type at the top level causes the encoder to bypass the pointer-handling logic that writes a presence marker ( Trying to fix this may breaks the protocol behavior, so I will not create a pull request to fix it. |
|
The *reflect portion of the varbin package appears to only include the following use cases:
Its original purpose was to prevent problems with manually written libbox serialization, but it seems to have many bugs, and I believe we can safely remove this package soon. |
|
I apologize for informing you that I am reverting your two fix commits because I pushed them to the sing-box stable branch without verifying compatibility, and they caused production breakage. Since I will be removing the use of varbin serialization in 1.13, and 1.13 will soon be the new stable release, I also reverted them in sing dev for compatibility testing. |
_,CanSet()returns false.||) operation skipsCanSet()check, causing panic.