Add ML worker CI and PR template#84
Conversation
|
Caution Review failedPull request was closed or merged during review 📝 WalkthroughWalkthroughThis PR introduces a new GitHub Actions workflow for the ML worker package, redesigns the pull request template for structured hygiene, and updates documentation to align with the new testing and verification expectations across the repository. ChangesML Worker Testing CI and PR Template Standardization
Estimated code review effort🎯 2 (Simple) | ⏱️ ~12 minutes Possibly related PRs
Poem
🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
Tip 💬 Introducing Slack Agent: The best way for teams to turn conversations into code.Slack Agent is built on CodeRabbit's deep understanding of your code, so your team can collaborate across the entire SDLC without losing context.
Built for teams:
One agent for your entire SDLC. Right inside Slack. Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
SahilKumar75
left a comment
There was a problem hiding this comment.
Review pass 1: The workflow is scoped to worker paths and manual dispatch, which keeps unrelated app/backend changes out of this test job. Before merge, confirm the workflow file lands before relying on the badge in the worker README.
SahilKumar75
left a comment
There was a problem hiding this comment.
Review pass 2: The default PR template is short enough to fill in consistently. The verification section should stay command-based; avoid adding broad checklist items that reviewers cannot verify from the diff.
Summary
Linked Issue
Closes #79
Closes #83
What Changed
.github/workflows/ml-worker.ymlfor Python 3.11 and 3.12 worker tests..github/pull_request_template.mdto require issue links, verification, review notes, and risks.Verification
cd app && npx tsc --noEmitcd backend && mvn testcd ml-worker && pytestattempted; collection currently stops on the pre-existingOperationMetricsimport mismatch intests/test_metrics.py.git diff --checkReview Notes
Risks And Follow-Up
Summary by CodeRabbit
Documentation
Chores