Merged
Conversation
…est-tests-and-workflow @W-19518850 - Fixing jest tests and github workflow
…a11y_tests Remove Sa11y workflow and fix one failure
…edge (#7302) * Implement instrumentation on the three RD Callable API's * Unit testing improvements * Add additional unit tests to validate other behavoirs * Add Instrumentation to the RD2 Nightly Batch job * Add instrumentation to the Contact Merge Service * Add Unit Test for Contact Merge Duplicate Record Set results * Manage Household Instrumentation (test pending) * Add unit tests for new instrumentation as well as for methods not tested * Add a static inner class to hold the last call values to use for test asserts * Add additional instrumentation service tests * Reset the saved naming setting after saving to avoid duplicate instrumentation * Remove elevate reference from the PR template --------- Co-authored-by: salesforce-org-metaci[bot] <53311887+salesforce-org-metaci[bot]@users.noreply.github.com>
…rceFoundation/NPSP into feature/260__robot-fixes
…-fixes @W-19315781 - Robot Fixes
…se-fixes @W-20174507 - Test fixes for 260 Feature Branch Failures
lparrott
requested review from
andrewyu-salesforce,
daniel-fuller and
ptewson-sfdo
…fixes @W-20174507 - Fixing 260 Feature Tests
force2b
approved these changes
Nov 13, 2025
lparrott
commented
Nov 13, 2025
| return OPP_StageMappingUtil.determineOppStateFromOppStage(oppStage); | ||
|
|
||
| } when 'crlp.getdefinitionsforrolluptype' { | ||
| } when 'crlp.getdefinitionsforrolluptype' { // internal use only, deprecated |
Contributor
Author
There was a problem hiding this comment.
I assume these comments are mostly for us when looking back at the code? And anyone else that looks I suppose, we can't actually prevent external usage though.
lparrott
commented
Nov 13, 2025
| } | ||
|
|
||
| HouseholdNamingService householdNamingService = new HouseholdNamingService(); | ||
| // TODO: Add instrumentation for the setNameFieldValuesOnHousehold method (Any Naming Override options changed on the page) |
Contributor
Author
There was a problem hiding this comment.
Looks like we missed this TODO, but it will have to wait!
|
|
||
| if (accountsToInsert.size() > 0 && (numHouseholdNamesSet > 0 || numFormalGreetingsSet > 0 || numInformalGreetingsSet > 0)) { | ||
| Map<String, Object> context = new Map<String, Object>{ | ||
| 'SourceClass' => 'HouseholdService' |
Contributor
There was a problem hiding this comment.
This is very non-blocking, but could get the class name here programatically. Arguably that adds complexity where it's not really helpful?
vsbharath
approved these changes
Nov 13, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes
Pull requests with no release notes
@W-20174507 - Fixing 260 Feature Tests [PR7314]
@W-20174507 - Test fixes for 260 Feature Branch Failures [PR7313]
@W-19137084 - Resolve NPSP settings page lightning error message [PR7312]
@W-19435408 - Introduce new Instrumentation to improve adoption knowledge (Part 2) [PR7310]
Remove Sa11y workflow and fix one failure [PR7308]
@W-19518850 - Fixing jest tests and github workflow [PR7303]
@W-19435389 - Introduce new Instrumentation to improve adoption knowledge [PR7302]
W-19274505 - Resolve MultiCurrency Beta Build Test Failure @testfix@ [PR7300]