This repository was archived by the owner on Jan 20, 2024. It is now read-only.
Datepicker fix for other locales than en_US on ActionPlanCreation#11
Conversation
… code did some hard coded parsing and expected all dates to be formatted MM/dd/yyyy. For other locales which format dates e.g. dd.MM.yyyy, the code failed and the DatePicker in the "days after" column did not show the target dates or failed to open.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The JS file ActionPlanCreationScripts contains logic which expects all dates to be formatted MM/dd/yyyy. In European countries e.g. the typical format is dd/MM/yyyy.
The date picker then is completely screwed up. It is not displayed at all or the target date is not shown.
Reproduce: Set locale (not language) to e.g. German or Spanish and create a new action plan e.g. on Contact. Check the DatePicker.
This fix now supports dates in other locales than en_US. The original code did some hard coded parsing and expected all dates to be formatted MM/dd/yyyy. For other locales which format dates e.g. dd.MM.yyyy, the code failed and the DatePicker in the "days after" column did not show the target dates or failed to open.
It makes usage of the DateUtil javascript class in main.js, thus the methods are not documented but as the AP code uses the DatePicker already (which depends on the DateUtil class too) I think it's an acceptable risk compared to the previous hard coded routines that are known to fail in most of the countries.