docs: require Build gate in the §9 required-checks note#229
Merged
Conversation
…note Aligns the architecture note with #228: the gate workflows now always report (skip == passing check), so they can be required without blocking docs-/CI-only PRs. The matrix build's required-check target is the always-present aggregate "Build gate" (the per-OS "Build and test module (...)" contexts aren't created when the matrix job is skipped). Required set: Build gate, Validate upstream compatibility tooling, dependency-review. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
|
You have reached your Codex usage limits for code reviews. You can see your limits in the Codex usage dashboard. |
github-actions
Bot
added
the
documentation
Contributor
Up to standards ✅🟢 Issues
|
Contributor
Dependency Review✅ No vulnerabilities or license issues or OpenSSF Scorecard issues found.Scanned FilesNone |
Contributor
There was a problem hiding this comment.
Pull request overview
Updates the architecture documentation to reflect the new required-check target for the build workflow, aligning §9’s “required status checks” guidance with the “always-reporting” gate approach introduced in #228.
Changes:
- Updates §9 to recommend requiring the stable
Build gateaggregate check (instead of per-OS matrix legs) in branch protection / rulesets. - Clarifies the intended required-check set:
Build gate,Validate upstream compatibility tooling,dependency-review.
…header Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Aligns Architecture.md §9 with #228 — the required-check target for the matrix build is the always-present
Build gateaggregate (the per-OSBuild and test module (…)legs aren't created when the matrix job is skipped). Required set:Build gate,Validate upstream compatibility tooling,dependency-review.This is also the skip-path verification for #228: a docs-only PR touches no bundle/tooling paths, so both gates should skip-and-pass (
Build gategreen with the matrix skipped;Validate upstream compatibility toolingskipped). Confirming this before the ruleset is set to require them.🤖 Generated with Claude Code