fix: undefined placeholder method on empty gallery#3
Merged
Conversation
Gallery::getData('imageHelper') returns null — _imageHelper is a
protected property on the block, not block data — so calling
getDefaultPlaceholderUrl() on it fatals when a product has no gallery
images. Inject Magento\Catalog\Helper\Image directly instead.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes crash reported in SAM-44:
Call to a member function getDefaultPlaceholderUrl() on nullwhen a product has no gallery images.Gallery::getData('imageHelper')returns null —_imageHelperis a protected property on the block, not block data, so there's nothing under that data key. Fix injectsMagento\Catalog\Helper\Imageinto the observer directly instead of reaching into the block.Test plan
testUsesPlaceholderWhenGalleryHasNoImages) that reproduces the exact crash against the old code, and passes against the fix.samjuk/magento-ci-testing-env:2.4.8-p3-php8.3container used by CI, with the module required into a full Magento install via the local path repo (mirrors_local_test_dev.sh).