fix: master Enabled toggle not disabling PageBuilder preload scan#6
Merged
Merged
Conversation
BlockToHtmlAfter used && instead of || when checking the two config flags, so it only skipped when BOTH isEnabled() and isPageBuilderPreloadEnabled() were false. Turning the module's master "Enabled" switch off had no effect as long as the (default-on) pagebuilder_content toggle was left enabled — every other observer in the module already uses the correct || guard.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
BlockToHtmlAfter::execute()used&&instead of||:This only skips when both flags are false — so setting the master
samjuk_fetch_priority/general/enabledtoggle to No does nothing aslong as
preloads/pagebuilder_content(default: Yes) is still on.Every other observer in the module correctly uses
||(master switchgates everything).
Test plan
(
testExecutesWhenOnlyModuleEnabled/testExecutesWhenOnlyPageBuilderPreloadEnabled) to assert thecorrect behaviour instead.
Test/Unit/Observer/View/BlockToHtmlAfterTest.phpsuite passes(8/8) against Magento 2.4.8-p3/PHP 8.3.