Skip to content

Remove an unnecessary guard check #89

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
paulpela wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Remove an unnecessary guard check #89

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 1 addition & 4 deletions Sources/DiceKit/DieSide.swift
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,10 +14,7 @@ public struct DieSide<OutputType: Hashable>: Hashable {//If not Hashable, ensure
/// The value that this DieSide will return when rolled.
public let value: OutputType

public static func == (lhs: DieSide, rhs: DieSide) -> Bool { //IMPORTANT NOTE: THIS DOES NOT ACCEPT `DieSide`s WITH DIFFERENT GENERIC ARGUMENTS
guard type(of: lhs.value) == type(of: rhs.value) else {
return false
}
public static func == (lhs: DieSide, rhs: DieSide) -> Bool {
return lhs.value == rhs.value
}

Expand Down