Add trace logs to profile the shared memory synchronization.#195
Open
Sunwoo-Nam wants to merge 1 commit intoSamsung:castanets_69from
Open
Add trace logs to profile the shared memory synchronization.#195Sunwoo-Nam wants to merge 1 commit intoSamsung:castanets_69from
Sunwoo-Nam wants to merge 1 commit intoSamsung:castanets_69from
Conversation
The progress of the shared memory synchronization is very important on Castanets. We want to use Chrome trace to do that and time ticks between processes need to be synchronized. This CL still has a problem because the network delay affects timestamps. We better check only total memories transferred without a duration. Signed-off-by: Sunwoo Nam <sunny.nam@samsung.com>
| #endif | ||
| #if defined(CASTANETS) | ||
| if (std::string("renderer") == | ||
| base::CommandLine::ForCurrentProcess()->GetSwitchValueASCII("type")) { |
There was a problem hiding this comment.
how about defining like this ? for more easy modifications in future.
constexpr const char kProcessTypeSwitch[] = "type";
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The progress of the shared memory synchronization is very important
on Castanets. We want to use Chrome trace to do that and time ticks
between processes need to be synchronized.
This CL still has a problem because the network delay affects timestamps.
We better check only total memories transferred without a duration.