Skip to content

[quantization] Add quantization coverage check#543

Merged
dayo09 merged 1 commit intoSamsung:mainfrom
mhs4670go:val
Mar 10, 2026
Merged

[quantization] Add quantization coverage check#543
dayo09 merged 1 commit intoSamsung:mainfrom
mhs4670go:val

Conversation

@mhs4670go
Copy link
Contributor

@mhs4670go mhs4670go commented Mar 9, 2026

This commit checks if missing qparams exist after quant passes.

Example

[QuantCheck] WARNING: 2 nodes without qparam detected (see logs).
# in the log file
DEBUG:tico.quantization.wrapq.utils.check_missing_qparams:[QuantCheck] quantized nodes : 487
DEBUG:tico.quantization.wrapq.utils.check_missing_qparams:[QuantCheck] fp nodes        : 2
DEBUG:tico.quantization.wrapq.utils.check_missing_qparams:[QuantCheck] Missing qparam:
  name   : cat_65
  target : cat.default
  users  : 1
  trace  :   File "/home/seongwoo/TICO/tico/quantization/wrapq/wrappers/ptq_wrapper.py", line 68, in forward
    return self.wrapped(*args, **kwargs)
  File "/home/seongwoo/TICO/tico/quantization/wrapq/wrappers/llama/quant_decoder_layer_decode.py", line 219, in forward
    attn_out = self.self_attn(
  File "/home/seongwoo/TICO/tico/quantization/wrapq/wrappers/ptq_wrapper.py", line 68, in forward
    return self.wrapped(*args, **kwargs)
  File "/home/seongwoo/TICO/tico/quantization/wrapq/wrappers/llama/quant_attn_decode.py", line 312, in forward
    new_k = torch.stack(new_k_parts, dim=1)

DEBUG:tico.quantization.wrapq.utils.check_missing_qparams:[QuantCheck] Missing qparam:
  name   : reshape_default_101
  target : reshape.default
  users  : 1
  trace  :   File "/home/seongwoo/TICO/tico/quantization/wrapq/wrappers/ptq_wrapper.py", line 68, in forward
    return self.wrapped(*args, **kwargs)
  File "/home/seongwoo/TICO/tico/quantization/wrapq/wrappers/llama/quant_decoder_layer_decode.py", line 219, in forward
    attn_out = self.self_attn(
  File "/home/seongwoo/TICO/tico/quantization/wrapq/wrappers/ptq_wrapper.py", line 68, in forward
    return self.wrapped(*args, **kwargs)
  File "/home/seongwoo/TICO/tico/quantization/wrapq/wrappers/llama/quant_attn_decode.py", line 312, in forward
    new_k = torch.stack(new_k_parts, dim=1)

TICO-DCO-1.0-Signed-off-by: seongwoo mhs4670go@naver.com

This commit checks if missing qparams exist after quant passes.

TICO-DCO-1.0-Signed-off-by: seongwoo <mhs4670go@naver.com>
@mhs4670go mhs4670go requested a review from a team March 9, 2026 07:14
Copy link
Contributor

@dayo09 dayo09 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@dayo09 dayo09 merged commit 8311f80 into Samsung:main Mar 10, 2026
7 checks passed
@mhs4670go mhs4670go deleted the val branch March 10, 2026 04:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants