Migrate DllImport to LibraryImport in core modules#7489
Open
JoonghyunCho wants to merge 1 commit intoSamsung:mainfrom
Open
Migrate DllImport to LibraryImport in core modules#7489JoonghyunCho wants to merge 1 commit intoSamsung:mainfrom
JoonghyunCho wants to merge 1 commit intoSamsung:mainfrom
Conversation
Collaborator
Build Error: |
cf41b6f to
62c4b92
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of Change
This draft PR is about to migrate our P/Invoke declaration from
[DllImport]to the modern[LibraryImport]source generator.The main goal of this refactoring is to:
What is included in the PR?
[LibraryImport]withpartialmodifiers to safe, core platform modules.StringMarshalling = StringMarshalling.Utf8for generated interoperability.What is excluded in the PR and Why?
Reason for Exclusion: Lack of support for HandleRef marshaling and the constraints of the SWIG auto-generated structure.
While most of the Tizen.Multimedia namespace has been successfully converted, some methods in specific files such as
Interop.Volume.csandInterop.Device.csstill utilize [DllImport].Reason for Exclusion: Requirements for CallingConvention.Cdecl and the inherent complexity of delegate marshaling.
Reason for Omission: Projects including Tizen.Uix.* (Voice Index, TTS models), Tizen.Telephony.*, and Tizen.Pims.Contacts are currently out of scope due to the priority.