remove 'unused step' warnings from kernels without pd#737
Open
pkienzle wants to merge 1 commit into
Open
Conversation
krzywon
approved these changes
Jun 9, 2026
krzywon
left a comment
Collaborator
There was a problem hiding this comment.
Code seems reasonable. Haven't tested.
Contributor
Author
|
CI runs C models with and without polydipersity. Since everything still passes it doesn't break anything. Showing that the warning doesn't appear on your system is more complicated because compiler output is suppressed if there are no errors. I modified ...
#warning "this is a warning"
#error "this is an error"then ran the model under cpu and gpu respectively: python -m sasmodels.compare -single! guinier
python -m sasmodels.compare -single guinierIn this branch on mac os I only got the above warning and error. On master I got the unused variable warning for |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
For models without polydispersity, the c compiler was returning warnings about an unused step parameter for every variant of the calculator (Iq, Iqxy, Imagnetic). This made it hard to see the actual error.
After the fix the following
becomes