Rigid-body refinement#3997
Draft
klytje wants to merge 9 commits into
Draft
Conversation
Contributor
Author
|
Is this something that would be useful to include in SasView? And if so, any thoughts on how it could be better integrated? |
Member
|
If I'm understanding this correctly, it would live most naturally in the GSC, particularly within the context of the refactoring project on that. This is probably worth a discussion at a meeting? Particularly as the GSC group is hoping to be at a point of moving from design to actual restructuring by the time of the next contributor camp in Prague? |
Member
|
I should have called out @wpotrzebowski as he is leading the GSC refactor |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This is still a work in progress.
This PR provides a new tool for performing rigid-body refinement via the config scripting language of
pyAUSAXS. Most of the work has gone into developing a basic typechecker for this purpose.Review Checklist:
[if using the editor, use
[x]in place of[ ]to check a box]Documentation (check at least one)
Installers
Licensing (untick if necessary)