Skip to content

Rigid-body refinement#3997

Draft
klytje wants to merge 9 commits into
mainfrom
rigidbody_refinement
Draft

Rigid-body refinement#3997
klytje wants to merge 9 commits into
mainfrom
rigidbody_refinement

Conversation

@klytje

@klytje klytje commented Jun 10, 2026

Copy link
Copy Markdown
Contributor

Description

This is still a work in progress.

This PR provides a new tool for performing rigid-body refinement via the config scripting language of pyAUSAXS. Most of the work has gone into developing a basic typechecker for this purpose.

image

Review Checklist:

[if using the editor, use [x] in place of [ ] to check a box]

Documentation (check at least one)

  • Documentation missing

Installers

  • There is a chance this will affect the installers, if so
    • Windows installer (GH artifact) has been tested (installed and worked)
    • MacOSX installer (GH artifact) has been tested (installed and worked)
    • Wheels installer (GH artifact) has been tested (installed and worked)

Licensing (untick if necessary)

  • The introduced changes comply with SasView license (BSD 3-Clause)

@klytje

klytje commented Jun 10, 2026

Copy link
Copy Markdown
Contributor Author

Is this something that would be useful to include in SasView? And if so, any thoughts on how it could be better integrated?

@krzywon krzywon requested a review from butlerpd June 16, 2026 13:39
@butlerpd

Copy link
Copy Markdown
Member

If I'm understanding this correctly, it would live most naturally in the GSC, particularly within the context of the refactoring project on that. This is probably worth a discussion at a meeting? Particularly as the GSC group is hoping to be at a point of moving from design to actual restructuring by the time of the next contributor camp in Prague?

@butlerpd

Copy link
Copy Markdown
Member

I should have called out @wpotrzebowski as he is leading the GSC refactor

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants