4010 typo on whats new screen#4027
Conversation
* don't include magnetism parameters in pure python models * update magnetism test to use a model that supports magnetism --------- Co-authored-by: Paul Kienzle <pkienzle@nist.gov>
* adding polyhedrons in WhatsNew * changing htlm description * Corrects png to jpg * Reorder pages --------- Co-authored-by: jellybean2004 <sujayashr18@gmail.com>
Co-authored-by: sujaya <88585975+jellybean2004@users.noreply.github.com>
* Fix sas.models suppression to not accidentally allow private members in sphinx * Allow ruff to tidy conf.py
* Delete slicer if its 1D plot is deleted * Update slicer list after deletion * Fix for annulus making other slicers nonmoveable * Remove boxsum when window is closed * Fix boxsum error messages * Handle deletion of 2D plot * Add tests * Properly change/delete params shown
* Add documentation * Add documentation * Add documentation * update * Removes break --------- Co-authored-by: Christian Wögerbauer <christian.woegerbauer@gmx.de> Co-authored-by: jellybean2004 <sujayashr18@gmail.com>
* Remove the n_shells text setting to prevent mirroring of the value in the fitting widget. * Remove gaussian from the checked_list to not always have the word gaussian over top of the combobox --------- Co-authored-by: sujaya <88585975+jellybean2004@users.noreply.github.com>
|
Thanks for this PR @dehoni, but I sincerely hope fixing a typo does not require adding over 1000 lines of code! Could you please review your branches for us? |
|
@dehoni The release branch for 6.2 was recently merged into |
|
Ok, this PR and #4026 are based on the unmerged branch |
|
@DrPaulSharp rebasing to main would delete the folder WhatsNew/messages/6.2.0 and all its content and (for completeness) also "build_tools/application_metadata/org.sasview.sasview.metainfo.xml". Is this intended? |
|
@dehoni Yes, that is the intention. @jellybean2004 is handling how these files will be included in main in #4020, and will make sure this change is included in the release. Please rebase this branch, such that the PR only acts to fix the typo you mentioned (and similarly for #4026). |
|
This page will probably be changed as per issue #4011. So, I was waiting to correct the typo. But the merge should point to the release_6.2.0 branch |
|
Closing this in favour of a fix for #4011 that will be in the release candidate. |
Description
The PR fixed #4010 the typo in one of the What's new messages.
How Has This Been Tested?
Review Checklist:
[if using the editor, use
[x]in place of[ ]to check a box]Documentation (check at least one)
Installers
Licensing (untick if necessary)