Skip to content

4010 typo on whats new screen#4027

Closed
dehoni wants to merge 25 commits into
mainfrom
4010-typo-on-whats-new-screen
Closed

4010 typo on whats new screen#4027
dehoni wants to merge 25 commits into
mainfrom
4010-typo-on-whats-new-screen

Conversation

@dehoni

@dehoni dehoni commented Jul 2, 2026

Copy link
Copy Markdown
Contributor

Description

The PR fixed #4010 the typo in one of the What's new messages.

How Has This Been Tested?

Review Checklist:

[if using the editor, use [x] in place of [ ] to check a box]

Documentation (check at least one)

  • [ X] There is nothing that needs documenting
  • Documentation changes are in this PR
  • There is an issue open for the documentation (link?)

Installers

  • There is a chance this will affect the installers, if so
    • Windows installer (GH artifact) has been tested (installed and worked)
    • MacOSX installer (GH artifact) has been tested (installed and worked)
    • Wheels installer (GH artifact) has been tested (installed and worked)

Licensing (untick if necessary)

  • The introduced changes comply with SasView license (BSD 3-Clause)

jellybean2004 and others added 23 commits May 18, 2026 10:23
* don't include magnetism parameters in pure python models

* update magnetism test to use a model that supports magnetism

---------

Co-authored-by: Paul Kienzle <pkienzle@nist.gov>
* adding polyhedrons in WhatsNew

* changing htlm description

* Corrects png to jpg

* Reorder pages

---------

Co-authored-by: jellybean2004 <sujayashr18@gmail.com>
Co-authored-by: sujaya <88585975+jellybean2004@users.noreply.github.com>
* Fix sas.models suppression to not accidentally allow private members in sphinx

* Allow ruff to tidy conf.py
* Delete slicer if its 1D plot is deleted

* Update slicer list after deletion

* Fix for annulus making other slicers nonmoveable

* Remove boxsum when window is closed

* Fix boxsum error messages

* Handle deletion of 2D plot

* Add tests

* Properly change/delete params shown
* Add documentation

* Add documentation

* Add documentation

* update

* Removes break

---------

Co-authored-by: Christian Wögerbauer <christian.woegerbauer@gmx.de>
Co-authored-by: jellybean2004 <sujayashr18@gmail.com>
* Remove the n_shells text setting to prevent mirroring of the value in the fitting widget.

* Remove gaussian from the checked_list to not always have the word gaussian over top of the combobox

---------

Co-authored-by: sujaya <88585975+jellybean2004@users.noreply.github.com>
@dehoni dehoni linked an issue Jul 2, 2026 that may be closed by this pull request
@dehoni dehoni added SasView 6.2.0 Housekeeping Tidying, renaming, formatting, minor refactoring, boring stuff in general labels Jul 2, 2026
@DrPaulSharp

Copy link
Copy Markdown
Contributor

Thanks for this PR @dehoni, but I sincerely hope fixing a typo does not require adding over 1000 lines of code! Could you please review your branches for us?

@DrPaulSharp

DrPaulSharp commented Jul 2, 2026

Copy link
Copy Markdown
Contributor

@dehoni The release branch for 6.2 was recently merged into main so it's most likely your version of main is behind that. Let me know if you need a hand.

@DrPaulSharp

Copy link
Copy Markdown
Contributor

Ok, this PR and #4026 are based on the unmerged branch merge_release_6.2.0b1 instead of main. You'll need to rebase before we can proceed. Let me know if you need a hand with that.

@dehoni

dehoni commented Jul 3, 2026

Copy link
Copy Markdown
Contributor Author

@DrPaulSharp rebasing to main would delete the folder WhatsNew/messages/6.2.0 and all its content and (for completeness) also "build_tools/application_metadata/org.sasview.sasview.metainfo.xml". Is this intended?

@DrPaulSharp

Copy link
Copy Markdown
Contributor

@dehoni Yes, that is the intention. @jellybean2004 is handling how these files will be included in main in #4020, and will make sure this change is included in the release. Please rebase this branch, such that the PR only acts to fix the typo you mentioned (and similarly for #4026).

@jellybean2004

Copy link
Copy Markdown
Member

This page will probably be changed as per issue #4011. So, I was waiting to correct the typo.

But the merge should point to the release_6.2.0 branch

@jellybean2004

Copy link
Copy Markdown
Member

Closing this in favour of a fix for #4011 that will be in the release candidate.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Housekeeping Tidying, renaming, formatting, minor refactoring, boring stuff in general SasView 6.2.0

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Typo on What's New screen

8 participants