Skip to content

Remove old cards in What's New#4046

Open
jellybean2004 wants to merge 3 commits into
release_6.2.0from
fix_whats_new
Open

Remove old cards in What's New#4046
jellybean2004 wants to merge 3 commits into
release_6.2.0from
fix_whats_new

Conversation

@jellybean2004

Copy link
Copy Markdown
Member

Description

Updated the logic to only include the messages for the latest release if the flag is set to only_recent.

Fixes #3985

How Has This Been Tested?

Manually tested in the build.

Review Checklist:

Documentation

  • There is nothing that needs documenting
  • Documentation changes are in this PR
  • There is an issue open for the documentation (link?)

Installers

  • There is a chance this will affect the installers, if so
    • Windows installer (GH artifact) has been tested (installed and worked)
    • MacOSX installer (GH artifact) has been tested (installed and worked)
    • Wheels installer (GH artifact) has been tested (installed and worked)

Licensing

  • The introduced changes comply with SasView license (BSD 3-Clause)

@DrPaulSharp DrPaulSharp left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ok, a few things here:

  • The What's New menu is no longer displayed when starting SasView
  • The arrows and page numbers are missing (does this branch need rebasing?)
  • Whilst we're here, the "Send to Data Explorer" page needs to be updated to "Freeze Datasets", as do all of the recent screenshots (sorry about that!)
  • When accessing "What's New" from the help, I'm finding the pages going back to version 6.0.0 - is this intended?

@jellybean2004

Copy link
Copy Markdown
Member Author

Ok, a few things here:

  • The What's New menu is no longer displayed when starting SasView
  • The arrows and page numbers are missing (does this branch need rebasing?)
  • Whilst we're here, the "Send to Data Explorer" page needs to be updated to "Freeze Datasets", as do all of the recent screenshots (sorry about that!)
  • When accessing "What's New" from the help, I'm finding the pages going back to version 6.0.0 - is this intended?

Thanks for the feedback @DrPaulSharp.

#4035 was merged into main. Since it is technically not a 6.2.0 bug fix, I did not put it in the release.

This PR is based on the release branch to test that only 6.2.0 messages are displayed

I'll have a look at the other points.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants