Conversation
- Updated `tests/unit/infrastructure/adapters/test_client_retry_mixin.py` to import and call `_can_retry` and `_record_request_metrics` from the module directly, as these were refactored into module-level functions in `src/bioetl/infrastructure/adapters/http/client_retry_mixin.py`. - Fixed `test_atomic.py` and `test_metadata_writer.py` mocks `flaky_replace` to throw a cross-platform retryable error `OSError(16, "Device or resource busy")` instead of `OSError(13)`, restoring full test execution on non-Windows FS. Co-authored-by: SatoryKono <13055362+SatoryKono@users.noreply.github.com>
|
👋 Jules, reporting for duty! I'm here to lend a hand with this pull request. When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down. I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job! For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with New to Jules? Learn more at jules.google/docs. For security, I will only act on instructions from the user who triggered this task. |
|
Closing: stale branch, content outdated or superseded by main. |
|
Closing: stale, conflicts with P3/P5 optimizations. |
|
Closing: stale, conflicts with P3/P5. |
1 participant
Fixing unit test failures in the BioETL infrastructure module.
Issues addressed:
tests/unit/infrastructure/adapters/test_client_retry_mixin.pytests were failing because_can_retryand_record_request_metricswere called as methods onclient, when they are now module-level helper functions inclient_retry_mixin.py.tests/unit/infrastructure/storage/test_atomic.pyandtest_metadata_writer.pytests were failing due to a hardcoded non-retryable permission error (OSError(13)) in the mocked file replace function on non-Windows filesystems, which has been corrected to use the globally retryable error (OSError(16)).PR created automatically by Jules for task 5165692915446266377 started by @SatoryKono