fix(cli): resolve CPR/UUID login queries to the userId#15
Merged
Conversation
`mitid login` passed the raw query straight to MitID identify, which only accepts a userId, so a CPR or UUID (both documented as valid queries) failed with identity_not_found. Use the userId from the already-resolved identity instead, so alias, userId, CPR, and UUID all work.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
mitid loginpassed the raw query straight to MitID identify, which only accepts auserId. So a CPR or UUID (both documented as valid queries, and whatresolveQueryfalls through on) failed withidentity_not_found— e.g.mitid login 0101900001 <url>.The login command already resolves the identity (the lookup handles userId, CPR, and UUID). This uses the resolved
identity.userIdas the username handed tologin(), so alias, userId, CPR, and UUID all work. On--no-approvethe lookup is best-effort and falls back to the raw query.