feat(claude-code-settings): add autoUpdate to extraKnownMarketplaces#5528
Closed
TiranSpierer wants to merge 2 commits intoSchemaStore:masterfrom
Closed
feat(claude-code-settings): add autoUpdate to extraKnownMarketplaces#5528TiranSpierer wants to merge 2 commits intoSchemaStore:masterfrom
TiranSpierer wants to merge 2 commits intoSchemaStore:masterfrom
Conversation
The `autoUpdate` boolean property is defined in Claude Code's source (`ExtraKnownMarketplaceSchema` in `src/utils/settings/types.ts`) but was missing from the SchemaStore schema. This caused false validation errors when configuring marketplace auto-updates in settings.json.
Contributor
|
Thanks for the PR! This section of the codebase is owned by @domdomegg, @bogini, and @ant-kurt - if they write a comment saying "LGTM" then it will be merged. |
for more information, see https://pre-commit.ci
There was a problem hiding this comment.
Pull request overview
This PR updates the claude-code-settings JSON Schema to accept the autoUpdate boolean in extraKnownMarketplaces entries, aligning SchemaStore validation with Claude Code’s documented/settings behavior and preventing false validation errors caused by additionalProperties: false.
Changes:
- Added optional
autoUpdate: booleantoextraKnownMarketplacesmarketplace entry objects in the schema. - Added a new positive test fixture covering
autoUpdate: trueandautoUpdate: falsefor different marketplace sources.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| src/schemas/json/claude-code-settings.json | Allows autoUpdate on extraKnownMarketplaces entries so valid user configs don’t fail validation. |
| src/test/claude-code-settings/marketplace-auto-update.json | Adds a positive test case exercising autoUpdate with github and git marketplace sources. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
autoUpdateboolean property toextraKnownMarketplacesentriesContext
The
autoUpdateproperty is defined in Claude Code's source (ExtraKnownMarketplaceSchemainsrc/utils/settings/types.ts) and documented in the official docs, but was missing from the SchemaStore schema.Because
additionalProperties: falseis set on the marketplace entry object, this causes false validation errors for users who configureautoUpdatein theirsettings.json.Test plan
src/test/claude-code-settings/marketplace-auto-update.jsonnode ./cli.js check --schema-name=claude-code-settings.jsonpasses