Skip to content

Migrate to using Microsoft ILogger abstraction#146

Merged
cbrady merged 4 commits into
SchematicHQ:mainfrom
Hawxy:ilogger
Jul 6, 2026
Merged

Migrate to using Microsoft ILogger abstraction#146
cbrady merged 4 commits into
SchematicHQ:mainfrom
Hawxy:ilogger

Conversation

@Hawxy

@Hawxy Hawxy commented Apr 29, 2026

Copy link
Copy Markdown
Contributor

I mentioned this to Ryan as the other breaking change that'd be useful to do at the same time as the cache abstractions for pluggability.

  • Eliminates the custom logging interface.
  • Adjusts the log structure to use named placeholders and ensures exception stack traces get properly reported.
  • Migrates the tests to use the Microsoft-supplied testing abstractions

There's an additional advantage that the logs could be migrated to use source-generated logging down the road to avoid allocations when specific log levels are disabled.

I've kept the console logger enabled out of the box as before.

@Hawxy
Hawxy requested a review from a team as a code owner April 29, 2026 15:44
Comment thread src/SchematicHQ.Client/Core/Public/ClientOptionsCustom.cs Outdated
@cbrady
cbrady merged commit b83bb1c into SchematicHQ:main Jul 6, 2026
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants