Skip to content

use wasm rulesengine#165

Open
cbrady wants to merge 2 commits into
mainfrom
chris/schy-473-migrate-schematic-csharp-to-use-the-wasm-rules-engine
Open

use wasm rulesengine#165
cbrady wants to merge 2 commits into
mainfrom
chris/schy-473-migrate-schematic-csharp-to-use-the-wasm-rules-engine

Conversation

@cbrady

@cbrady cbrady commented Jul 15, 2026

Copy link
Copy Markdown
Contributor

No description provided.

@cbrady cbrady self-assigned this Jul 15, 2026
@cbrady
cbrady requested a review from a team as a code owner July 15, 2026 16:26
bpapillon
bpapillon previously approved these changes Jul 16, 2026

@bpapillon bpapillon left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice.

A few things that could be followups:

  • I'm a little anxious in general about packaging and install concerns related to the wasm binary - given this is kind of a non-standard thing to do, it seems like there are a lot of places along the chain of development -> end user install (bundling, publishing from nuget, downloading from nuget, installing) for the wasm binary to disappear or fail to load, and this seems like the kind of failure mode that might manifest in different ways across language and packaging ecosystems, while also being hard to catch pre-merge (since packaging hasn't happened yet). The E2E tests migt be the right place to catch this - perhaps we can follow up by making sure we have E2E tests that will fully exercise at least one flag evaluation that runs through the wasm binary on a library version that was installed from the package manager? This may already be the case, but regardless, could you check on the E2E tests after this to confirm this. Lmk if this doesn't make sense we can talk about it live.
  • I was looking at GetVersionKey() - I'm not sure we actually use it in the cache-key as noted

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants