Render a monogram fallback for unknown icon names#1412
Draft
bpapillon wants to merge 1 commit into
Draft
Conversation
When an icon name isn't in the bundled icon set (commonly because the icon was added to schematic-icons after this build of schematic-components), Icon rendered the raw slug as text, which overflows the icon box. Detect emoji and pass them through unchanged; for unknown named slugs, render an uppercased first-letter monogram, keep the full name in the title attribute, and warn once per name.
|
🚀 Components Preview Deployed! 📍 Preview URL: https://schematic-next-example-6iijx4o2q-schematichq.vercel.app |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When an icon name isn't in the bundled icon set,
Iconrendered the raw slug as text, which overflows the icon box.Here, we change this fallback behavior so that emoji pass through unchanged (as before) but non-emoji unknown named slugs render an uppercased first-letter monogram, so it fits better in the icon box.